xuefuz commented on a change in pull request #8458: [FLINK-12452][table][hive] 
alterTable() should ensure existing base table and the new one are of the same 
type
URL: https://github.com/apache/flink/pull/8458#discussion_r284880162
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalogBase.java
 ##########
 @@ -318,13 +320,44 @@ public void alterTable(ObjectPath tablePath, 
CatalogBaseTable newCatalogTable, b
                                        throw new 
TableNotExistException(catalogName, tablePath);
                                }
                        } else {
 
 Review comment:
   It's probably better to fix it now while it's still warm.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to