bowenli86 commented on a change in pull request #8458:
[FLINK-12452][table][hive] alterTable() should ensure existing base table and
the new one are of the same type
URL: https://github.com/apache/flink/pull/8458#discussion_r284892066
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalogBase.java
##########
@@ -318,13 +320,44 @@ public void alterTable(ObjectPath tablePath,
CatalogBaseTable newCatalogTable, b
throw new
TableNotExistException(catalogName, tablePath);
}
} else {
Review comment:
Ok. I fixed in source repo and rebased this PR to master, and the rebase
took quite some time even though it's a small change.
In the future I think we should follow [Apache Flink Code Style and Quality
Guide](https://docs.google.com/document/d/1JGRVK6udBFa8xbyv7ipPQiLEhxebA64f8KKcaAH0UPY/edit#heading=h.i11eha8b46sj).
In section ""Separate Refactoring, Cleanup and Independent Changes" it
clarifies that such change should be on its own.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
