sunjincheng121 commented on a change in pull request #8401:
[FLINK-12407][python] Add all table operators align Java Table API.
URL: https://github.com/apache/flink/pull/8401#discussion_r284944545
##########
File path: flink-python/pyflink/table/tests/test_environment_completeness.py
##########
@@ -38,8 +38,8 @@ def excluded_methods(cls):
# registerFunction and listUserDefinedFunctions should be supported
when UDFs supported.
# registerExternalCatalog, getRegisteredExternalCatalog and listTables
# should be supported when catalog supported in python.
- return {'registerExternalCatalog', 'getRegisteredExternalCatalog',
- 'registerFunction', 'listUserDefinedFunctions', 'listTables'}
+ return {'registerExternalCatalog', 'getRegisteredExternalCatalog',
'connect',
+ 'registerFunction', 'listUserDefinedFunctions', 'listTables',
'getCompletionHints'}
Review comment:
Can you add the comment for why we excluded the `getCompletionHints`?
such as `Will be removed in the next release`. What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
