zhijiangW commented on issue #8242: [FLINK-6227][network] Introduce the PartitionException for downstream task failure URL: https://github.com/apache/flink/pull/8242#issuecomment-493335619 @tillrohrmann I have updated the codes for the following issues: - Refactor the previous existing `PartitionException` to `PartitionUpdateException` - Introduce the new abstract `PartitionException` - Make existing `PartitionNotFoundException` extend `PartitionException` - Although the existing tests of `TaskExecutorSubmissionTest#testRemotePartitionNotFound` and `TaskExecutorSubmissionTest#testLocalPartitionNotFound` could verify the whole process, but I still added some new tests to verify tiny process in separate component. - Adds new test for `ResultPartitionManager#createSubpartitionView` to make sure `ResultPartitionManager` throw `PartitionNotFoundException`. - Adds new test for `PartitionRequestServerHandler` to make sure the server would not swallow the `PartitionNotFoundException` thrown by `ResultPartitionManager`. - Adds new test for `LocalInputChannel#requestSubpartition` to make sure local channel throw `PartitionNotFoundException`. - Adds new test for `RemoteInputChannel#retriggerSubpartitionRequest` to make sure remote channel throw `PartitionNotFoundException`. - Adds new test for `SingleInputGate#getNextBufferOrEvent` to make sure `PartitionNotFoundException` would not be swallowed by `SingleInputGate`. - I am not sure whether it is necessary to further verify every component between task and `SingleInputGate` in order to confirm the `PartitionNotFoundException` would not be swallowed by any intermediate components, such as `UnionInputGate`, `BarrierBuffer/Tracker`, `Stream(Two)InputProcessor`, various of instances of `StreamTask`. - `PartitionCorruptionException` would not happen in current `BoundedBlockingSubpartition#createSubpartitionView`, so this PR does not focus on it now.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
