azagrebin commented on a change in pull request #8445:
[FLINK-12127][network,config] Move network related options form
TaskManagerOptions and NettyConfig into NetworkEnvironmentOptions
URL: https://github.com/apache/flink/pull/8445#discussion_r284995109
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java
##########
@@ -97,6 +97,21 @@
" different TaskManagers need different values
for this option, usually it is specified in an" +
" additional non-shared TaskManager-specific
config file.");
+ /**
Review comment:
True, `HOST_BIND_POLICY` probably belongs here better, but I would consider
to preserve github history and leave it where it was as there are already too
many options anyways in this class and order does look to matter anymore :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
