Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1079#discussion_r39030716
--- Diff:
flink-staging/flink-hcatalog/src/test/scala/org/apache/flink/hcatalog/scala/test/HCatInputOutputFormatITest.scala
---
@@ -0,0 +1,216 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.hcatalog.scala.test
+
+
+import java.io.{FileWriter, FileReader, BufferedReader, IOException, File}
+
+import org.apache.commons.io.FileUtils
+import org.apache.flink.api.scala.{DataSet, ExecutionEnvironment, _}
+import org.apache.flink.hcatalog.scala.{HCatInputFormat, HCatOutputFormat}
+import org.apache.hadoop.hive.cli.CliSessionState
+import org.apache.hadoop.hive.conf.HiveConf
+import org.apache.hadoop.hive.ql.Driver
+import org.apache.hadoop.hive.ql.session.SessionState
+import org.junit.Assert._
+import org.junit.rules.ExpectedException
+import org.junit.{Rule, After, Before, Test}
+
+class HCatInputOutputFormatITest {
+ private var dataDir: File = null
+ private var warehouseDir: String = null
+ private var inputFileName: String = null
+ private var driver: Driver = null
+ private var input: Array[String] = null
+ private var hiveConf: HiveConf = null
+
+ @Before
+ @throws(classOf[Exception])
+ def setup {
+ dataDir = new File(System.getProperty("java.io.tmpdir") +
File.separator +
+ this.getClass.getCanonicalName + "-" + System.currentTimeMillis)
+ hiveConf = new HiveConf
+ warehouseDir = makePathASafeFileName(dataDir + File.separator +
"warehouse")
+ hiveConf.set(HiveConf.ConfVars.PREEXECHOOKS.varname, "")
+ hiveConf.set(HiveConf.ConfVars.POSTEXECHOOKS.varname, "")
+ hiveConf.set(HiveConf.ConfVars.HIVE_SUPPORT_CONCURRENCY.varname,
"false")
+ hiveConf.set(HiveConf.ConfVars.METASTOREWAREHOUSE.varname,
warehouseDir)
+ driver = new Driver(hiveConf)
+ SessionState.start(new CliSessionState(hiveConf))
+ if (!(new File(warehouseDir).mkdirs)) {
+ throw new RuntimeException("Could not create " + warehouseDir)
+ }
+ }
+
+ @After
+ @throws(classOf[IOException])
+ def teardown {
+ if (dataDir != null) {
+ FileUtils.deleteDirectory(dataDir)
+ }
+ }
+
+ @Test
+ @throws(classOf[Exception])
+ def testReadTextFile {
+ inputFileName = makePathASafeFileName(dataDir + File.separator +
"input1.data")
+
+ input = Array[String]("a1/b1/c1\t1:v11/2:v12\td/1\te1\t0.1",
+ "a2/b2/c2\t1:v21/2:v22\td/2\te2\t0.2")
+
+ createTestDataFile(inputFileName, input)
+
+ val createTable: String = "CREATE TABLE test_table(" +
+ "c1 array<string>,\n" +
+ "c2 map<int,string>,\n" +
+ "c3 struct<name:string,score:int>,\n" +
+ "c4 string,\n" +
+ "c5 float)\n" +
+ "row format delimited " +
+ "fields terminated by '\t' " +
+ "COLLECTION ITEMS TERMINATED BY '/' " +
+ "MAP KEYS TERMINATED BY ':' " +
+ "STORED AS TEXTFILE"
+ driver.run("drop table test_table")
+ val retCode1: Int = driver.run(createTable).getResponseCode
+ assertTrue("table created", retCode1 == 0)
+ val loadTable: String = "load data inpath '" + inputFileName + "' into
table test_table"
+ val retCode2: Int = driver.run(loadTable).getResponseCode
+ assertTrue("table data loaded", retCode2 == 0)
+
+ val env: ExecutionEnvironment =
ExecutionEnvironment.createCollectionsEnvironment
+ val ipf: HCatInputFormat[(List[String], Map[Int, String], List[Any],
String, Float)] =
+ new HCatInputFormat(null, "test_table", hiveConf).asFlinkTuples().
+ asInstanceOf[HCatInputFormat[(List[String], Map[Int, String],
List[Any], String, Float)]]
+ val d: DataSet[(List[String], Map[Int, String], List[Any], String,
Float)] =
+ env.createInput(ipf)
+ val l = d.collect
+
+ //verify the first row
+ l.head match {
+ case Tuple5(List("a1","b1","c1"), _, List("d", 1), "e1", 0.1f) =>
//Map is not case class
+ case _ => fail()
+ }
+ //verify the Map item ignored in the pattern matching above
+ assertEquals(l.head._2(1), "v11")
+ assertEquals(l.head._2(2), "v12")
+ }
+
+ @Test
+ @throws(classOf[Exception])
+ def testWriteComplexTypeParition {
+ val createTable: String = "CREATE TABLE test_table(" +
+ "c1 array<string>,\n" +
+ "c2 map<int,string>,\n" +
+ "c3 struct<name:string,score:int>,\n" +
+ "c4 string,\n" +
+ "c5 float)\n" +
+ "partitioned by (c0 string)\n" +
+ "row format delimited " +
+ "fields terminated by '\t' " +
+ "COLLECTION ITEMS TERMINATED BY '/' " +
+ "MAP KEYS TERMINATED BY ':' " +
+ "STORED AS TEXTFILE"
+ driver.run("drop table test_table")
+ val retCode1: Int = driver.run(createTable).getResponseCode
+ assertTrue("Table created", retCode1 == 0)
+ val partitionValues: Map[String, String] = Map("c0" -> "part0")
+ val opf: HCatOutputFormat[(List[String], Map[Int, String], List[Any],
String, Float)] =
+ new HCatOutputFormat[(List[String], Map[Int, String], List[Any],
String, Float)](null,
+ "test_table", partitionValues, hiveConf)
+
+ val t1 = (List[String]("a1","b1","c1"), Map[Int, String](1 -> "v11", 2
-> "v12"),
+ List[Any]("d", 1), "e1", 0.1f)
+ val t2 = (List[String]("a2","b2","c2"), Map[Int, String](1 -> "v21", 2
-> "v22"),
+ List[Any]("d", 2), "e2", 0.2f)
+ val l: List[(List[String], Map[Int, String], List[Any], String,
Float)]=
+ List[(List[String], Map[Int, String], List[Any], String, Float)](t1,
t2)
+ val env: ExecutionEnvironment =
ExecutionEnvironment.createCollectionsEnvironment
+ val d: DataSet[(List[String], Map[Int, String], List[Any], String,
Float)] =
+ env.fromCollection(l)
+ d.output(opf)
+ env.execute
+ val outputFileName: String = makePathASafeFileName(warehouseDir +
+ File.separator + "test_table/c0=part0/part-m-00001")
+ val reader: BufferedReader = new BufferedReader(new
FileReader(outputFileName))
+ try {
+ var line: String = reader.readLine
+ assertEquals("1st row", line, "a1/b1/c1\t1:v11/2:v12\td/1\te1\t0.1")
+ line = reader.readLine
+ assertEquals("2nd row", line, "a2/b2/c2\t1:v21/2:v22\td/2\te2\t0.2")
+ reader.close
+ }
+ catch {
+ case e: Exception => {
+ e.printStackTrace
+ }
+ }
+ }
+
+ @Test
+ @throws(classOf[Exception])
+ def testTypeInfoCheck {
+ val createTable: String = "CREATE TABLE test_table(" +
+ "c1 array<string>,\n" +
+ "c2 map<int,string>,\n" +
+ "c3 struct<name:string,score:int>,\n" +
+ "c4 string,\n" +
+ "c5 float)\n" +
+ "partitioned by (c0 string)\n" +
+ "row format delimited " +
+ "fields terminated by '\t' " +
+ "COLLECTION ITEMS TERMINATED BY '/' " +
+ "MAP KEYS TERMINATED BY ':' " +
+ "STORED AS TEXTFILE"
+ driver.run("drop table test_table")
+ val retCode1: Int = driver.run(createTable).getResponseCode
+ assertTrue("Table created", retCode1 == 0)
+ val partitionValues: Map[String, String] = Map("c0" -> "part0")
+
+ //wrong type, should throw exception
+ try{
+ val opf =
+ new HCatOutputFormat[(List[String], Map[Int, String], List[Any],
Float, Float)](null,
+ "test_table", partitionValues, hiveConf)
+ } catch{
+ case ioe: IOException => //succeeded!
+ case _ => fail("expecting IOException!")
+ }
+ }
+
+ @throws(classOf[IOException])
+ def createTestDataFile(filename: String, lines: Array[String]) {
+ var writer: FileWriter = null
+ try {
+ val file: File = new File(filename)
+ file.deleteOnExit
+ writer = new FileWriter(file)
+ for (line <- lines) {
+ writer.write(line + "\n")
+ }
+ } finally {
+ if (writer != null) {
+ writer.close
+ }
+ }
+ }
+
+ def makePathASafeFileName(filePath: String): String = {
+ return new File(filePath).getPath.replaceAll("\\\\", "/")
--- End diff --
Do not need `return` for Scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
