pnowojski commented on a change in pull request #8442: [FLINK-12483] Support
(legacy) SourceFunction as special case in the mailbox model for stream tasks
URL: https://github.com/apache/flink/pull/8442#discussion_r285561422
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/SourceStreamTask.java
##########
@@ -98,12 +100,44 @@ protected void cleanup() {
}
@Override
- protected void run() throws Exception {
- headOperator.run(getCheckpointLock(),
getStreamStatusMaintainer());
+ protected void performDefaultAction(ActionContext context) throws
Exception {
+ // Against the usual contract of this method, this
implementation is not step-wise but blocking instead for
Review comment:
Ok, If I understand this correctly we have two choices:
1. (proposed in this PR) violate the contract of this method, hijack the
mailbox execution and add checkpoint lock handling here
2. keep the contract of this method, but spill the hopefully soon to be
deprecated checkpointing lock handling into the `StreamTask`
?
In that case you might be right that 1. sounds better.
One last question, have you considered how does this play with an idea of
dropping `SourceTasks` and just using `OneInputStreamTask` to handle them? Will
it be only possible for a connectors using new source interface and we would
still keep this `SourceStreamTask` as a compatibility layer? Or could we
somehow move this code to `OneInputStreamTask` as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
