zhijiangW commented on a change in pull request #8463: [FLINK-12530][network] 
Move Task.inputGatesById to NetworkEnvironment
URL: https://github.com/apache/flink/pull/8463#discussion_r285910860
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGateTest.java
 ##########
 @@ -542,6 +543,29 @@ public void testUpdateUnknownInputChannel() throws 
Exception {
                }
        }
 
+       @Test
+       public void checkInputGateRemoveInNetworkEnvironment() throws 
IOException {
+               NetworkEnvironment network = createNetworkEnvironment();
 
 Review comment:
   Do we need `network.shutdown()` in finally part?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to