zhijiangW opened a new pull request #8496: [FLINK-12571][network] Make NetworkEnvironment#start() return the binded data port URL: https://github.com/apache/flink/pull/8496 ## What is the purpose of the change *`NetworkEnvironment#getConnectionManager` is currently used for getting binded data port from `ConnectionManager`. Considering the general shuffle service architecture, the internal `ConnectionManager` in `NetworkEnvironment` should not be exposed to outsides. We could make `ShuffleService#start` return the binded data port directly if exists, then for other cases it could return a default int value which seems no harm.* ## Brief change log - *Make `ConnectionManager#start` return binded data port.* - *Make `NetworkEnvironment#start` return binded data port* - *Return legacy getter method in `NettyServer`* - *Refactor the process in `TaskManagerServices`* ## Verifying this change This change is a trivial rework / code cleanup without any test coverage. ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
