tillrohrmann commented on a change in pull request #8463:
[FLINK-12530][network] Move Task.inputGatesById to NetworkEnvironment
URL: https://github.com/apache/flink/pull/8463#discussion_r286568353
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/NetworkEnvironment.java
##########
@@ -97,13 +104,15 @@ private NetworkEnvironment(
NetworkBufferPool networkBufferPool,
ConnectionManager connectionManager,
ResultPartitionManager resultPartitionManager,
+ Map<IntermediateDataSetID, SingleInputGate>
inputGatesById,
Review comment:
Passing the map for storing the input gates into `NetworkEnvironment`
exposes in my opinion a bit too many implementation details of this structure.
I basically says that the object needs to store the `SingleInputGates` in this
structure. Otherwise the test will fail. I think it would be better to have a
`getInputGate(IntermediateDataSetID)` and let the way the gates are stored
internally be an implementation detail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
