[
https://issues.apache.org/jira/browse/FLINK-12602?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16846627#comment-16846627
]
Chesnay Schepler commented on FLINK-12602:
------------------------------------------
Mirroring my comment from the ML; there's no reason to keep that thread going
now that we have a JIRA.
There are 3 modules that have a suffix, which don't need it:
* flink-connector-hive
* flink-queryable-state-client-java
* flink-table-api-scala
All other modules do need it since they have dependencies with a scala-suffix
(mostly on runtime and streaming-java).
Your change does make sense to me, but there's likely another issue in the
preceding logic that determines which module is scala-free.
flink-tests for example should not be considered scala-free, since it relies on
flink-runtime which contains scala and hence the scala-lang dependencies, but
it apparently is given that your change detects something.
> Correct the flink pom `artifactId` config and scala-free check logic
> --------------------------------------------------------------------
>
> Key: FLINK-12602
> URL: https://issues.apache.org/jira/browse/FLINK-12602
> Project: Flink
> Issue Type: Bug
> Components: Build System
> Affects Versions: 1.9.0
> Reporter: sunjincheng
> Priority: Major
>
> I find a shell issue in `verify_scala_suffixes.sh`(line 145) as follows:
> {code}
> grep "${module}_\d\+\.\d\+</artifactId>" "{}"
> {code}
> This code want to find out all modules that the module's `artifactId` with a
> `scala_binary_version` suffix.
> but the problem is our all `artifactId` value is in the pattern of
> `XXX_${scala.binary.version}`, such as:
> {code}
> <artifactId>flink-tests_${scala.binary.version}</artifactId>
> {code}
> then the result always empty, so this check did not take effect.
> I have already initiated a discussion of the issue. Please check the Mail
> thread here for details.
> http://mail-archives.apache.org/mod_mbox/flink-dev/201905.mbox/%3ccajsjtkw+8mcsc0fvneyaovl_ttrr_uuosx-tfgxj5gfqp1a...@mail.gmail.com%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
