pnowojski commented on a change in pull request #7688: [FLINK-9816][network]
add option to configure SSL engine provider for TM communication
URL: https://github.com/apache/flink/pull/7688#discussion_r286984239
##########
File path: flink-end-to-end-tests/test-scripts/test_streaming_file_sink.sh
##########
@@ -22,8 +22,11 @@ OUT_TYPE="${1:-local}" # other type: s3
source "$(dirname "$0")"/common.sh
source "$(dirname "$0")"/common_s3.sh
+# randomly set up openSSL with dynamically/statically linked libraries
+OPENSSL_LINKAGE=$(if (( RANDOM % 2 )) ; then echo "dynamic"; else echo
"static"; fi)
Review comment:
Currently yes, but it would be safer to tie those two things together (best
hidden behind some function:
```
int x = new Random().nextInt();
System.out.println(format("Executing test with following value of x = [%s]
that was randomly selected", x));
```
), so that there is obvious connection between randomness and printing the
random result.
Otherwise, someone might remove the logging message, without realising the
implication of that fact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
