yanghua commented on issue #8322: [FLINK-12364] Introduce a CheckpointFailureManager to centralized manage checkpoint failure URL: https://github.com/apache/flink/pull/8322#issuecomment-496101546 Hi @StefanRRichter In the last few days, I did further refactor, include: * remove `org.apache.flink.runtime.checkpoint.decline.xxxException` and enumerate more reason in `CheckpointFailureReason` * remove `org.apache.flink.runtime.taskexecutor.exceptions.CheckpointException` and reused unified `org.apache.flink.runtime.checkpoint.CheckpointException` * temporarily ignore serval failure reason to keep compatibility with `failOnCheckpointingErrors ` There is just one issue left now. So would you mind to give a full review again? IMO, these refactor about checkpoint exception and the unified invocation for `PendingCheckpoint#abort` will be good for other issues.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services