azagrebin commented on a change in pull request #8459: [FLINK-12476] [State
TTL] Consider setting a default background cleanup strategy in StateTtlConfig
URL: https://github.com/apache/flink/pull/8459#discussion_r287802261
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/state/StateTtlConfig.java
##########
@@ -376,39 +391,57 @@ public StateTtlConfig build() {
private static final long serialVersionUID =
1373998465131443873L;
}
- final EnumMap<Strategies, CleanupStrategy> strategies = new
EnumMap<>(Strategies.class);
+ private final EnumMap<Strategies, CleanupStrategy> strategies =
new EnumMap<>(Strategies.class);
- public void activate(Strategies strategy) {
+ private void activate(Strategies strategy) {
activate(strategy, EMPTY_STRATEGY);
}
- public void activate(Strategies strategy, CleanupStrategy
config) {
+ private void activate(Strategies strategy, CleanupStrategy
config) {
strategies.put(strategy, config);
}
public boolean inFullSnapshot() {
return
strategies.containsKey(Strategies.FULL_STATE_SCAN_SNAPSHOT);
Review comment:
true, I thought about another method, sorry for confusion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
