zentol commented on a change in pull request #8545: [FLINK-12520] Support to
provide fully-qualified domain host name in TaskManagerMetricGroup
URL: https://github.com/apache/flink/pull/8545#discussion_r287806538
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/MetricOptions.java
##########
@@ -185,6 +185,14 @@
"faster updating metrics. Increase this value
if the metric fetcher causes too much load. Setting this value to 0 " +
"disables the metric fetching completely.");
+ /**
+ * Whether the host name in task manager metrics should be fully
qualified domain name.
+ */
+ public static final ConfigOption<Boolean> METRIC_FULL_HOST_NAME =
+ key("metrics.tm.full-hostname")
Review comment:
I'd rather introduce a new variable `<tm_fqdn>` then resorting to config
options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
