1u0 commented on a change in pull request #8523: [FLINK-12481][runtime] Invoke 
timer callback in task thread (via mailbox)
URL: https://github.com/apache/flink/pull/8523#discussion_r288235811
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
 ##########
 @@ -335,9 +335,9 @@ public final void invoke() throws Exception {
                        // if the clock is not already set, then assign a 
default TimeServiceProvider
                        if (timerService == null) {
                                ThreadFactory timerThreadFactory = new 
DispatcherThreadFactory(TRIGGER_THREAD_GROUP,
-                                       "Time Trigger for " + getName(), 
getUserCodeClassLoader());
+                                       "Time Trigger for " + getName());
 
 Review comment:
   Aitozi is right.
   It's a clean up (not needed functionality anymore).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to