lirui-apache commented on a change in pull request #8564: [FLINK-12649][hive] 
Add a shim layer to support multiple versions of HMS
URL: https://github.com/apache/flink/pull/8564#discussion_r288845200
 
 

 ##########
 File path: flink-connectors/flink-connector-hive/pom.xml
 ##########
 @@ -423,4 +423,22 @@ under the License.
                        </plugin>
                </plugins>
        </build>
+
+       <profiles>
+               <profile>
+                       <id>hive-1</id>
+                       <properties>
+                               <hive.version>1.2.1</hive.version>
+                               
<hivemetastore.hadoop.version>2.6.0</hivemetastore.hadoop.version>
+                       </properties>
+                       <dependencies>
+                               <dependency>
 
 Review comment:
   Because the 1.2.1 hive-exec jar doesn't include this dependency, and we 
excluded it from hive-metastore. BTW is there any reason why we excluded it 
from hive-metastore?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to