twalthr commented on a change in pull request #8549:
[FLINK-12604][table-api][table-planner] Register TableSource/Sink as
CatalogTables
URL: https://github.com/apache/flink/pull/8549#discussion_r289808239
##########
File path:
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/api/TableEnvImpl.scala
##########
@@ -425,20 +424,128 @@ abstract class TableEnvImpl(
"Only tables that belong to this TableEnvironment can be registered.")
}
- checkValidTableName(name)
Review comment:
Should we add least at some checks for non-empty strings and not only
whitespaces? Right now `registerTableInternal` fails in the check arguments of
`ObjectPath`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
