[ https://issues.apache.org/jira/browse/FLINK-2641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740421#comment-14740421 ]
Maximilian Michels commented on FLINK-2641: ------------------------------------------- {quote} Just a thought: Can we actually work without the taskmanager.memory.off-heap-ratio parameter? Simply use the taskmanager.memory.fraction as well for the off-heap case? We could multiply the specified heap size with the faction, take that as direct memory, and then take the remainder as the actual heap size. {quote} +1 That way, we keep the config lean. {quote} How about taskmanager.memory.size or taskmanager.memory.mb? {quote} :) {{taskmanager.memory.size}} is the memory size of the managed memory. {{taskmanager.memory.mb}} could be confused with the latter one as well. How about we rename that one to {{taskmanager.memory.managed.size}} and the fraction to {{taskmanager.memory.managed.fraction}}? That would also make sense from a hierarchical point of view. We could then name the combined memory {{taskmanager.memory.size}}. This may seem problematic because it breaks backwards-compatibility. We could solve that by detecting old configuration parameters and throwing an error. On the other hand, it's not that problematic because {{taskmanager.memory.size}} was not included in the configuration and probably few people know about it. ----------- Here's my proposal: || old || new || description || |{{taskmanager.memory.size}} | {{taskmanager.memory.managed.size}} | | |{{taskmanager.memory.fraction}} | {{taskmanager.memory.managed.fraction}} | (and let it work independent of heap and off-heap memory) | | {{taskmanager.heap.mb}} | {{taskmanager.memory.size}} | (and change it's meaning to combined JVM heap + off-heap memory) | | {{jobmanager.heap.mb}} | {{jobmanager.memory.size}} | | > Integrate the off-heap memory configuration with the TaskManager start script > ----------------------------------------------------------------------------- > > Key: FLINK-2641 > URL: https://issues.apache.org/jira/browse/FLINK-2641 > Project: Flink > Issue Type: New Feature > Components: Start-Stop Scripts > Affects Versions: 0.10 > Reporter: Stephan Ewen > Assignee: Maximilian Michels > Fix For: 0.10 > > > The TaskManager start script needs to adjust the {{-Xmx}}, {{-Xms}}, and > {{-XX:MaxDirectMemorySize}} parameters according to the off-heap memory > settings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)