Aitozi commented on issue #8280: [FLINK-12297]Harden ClosureCleaner to handle 
the wrapped function
URL: https://github.com/apache/flink/pull/8280#issuecomment-498756627
 
 
   I know your mean, and can we remove all the scattered `clean()` used in 
functions like `connector`, `Pattern`. Because IMO with the `RECURSIVE` level 
clean at the entrance showing below, I think other clean function can be 
removed, or make this less radical by use `TOP_LEVEL` in these scattered code 
path to keep old way. WDYT ? 
   
   ```
   public <F> F clean(F f) {
                if (getConfig().isClosureCleanerEnabled()) {
                        ClosureCleaner.clean(f, 
getConfig().getClosureCleanLevel(), true);
                }
                ClosureCleaner.ensureSerializable(f);
                return f;
        }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to