hequn8128 edited a comment on issue #8550: [FLINK-12401][table] Support incremental emit under AccRetract mode for non-window streaming FlatAggregate on Table API URL: https://github.com/apache/flink/pull/8550#issuecomment-498964537 @sunjincheng121 Thanks for the great summary. I think it's good to change the name to `emitUpdateWithRetract`. The table gives a clear picture of these methods. The `emitValue` can both be used for batch and streaming while the other two methods are used to enhance streaming cases. When we finish this PR, we can continue with the `emitUpdateWithoutRetract` once the discussion about key definition reaches a conclusion. I will change the method name soon and update the PR. Best, Hequn
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
