1u0 commented on a change in pull request #8539: [FLINK-12617] [container] 
StandaloneJobClusterEntrypoint defaults to random JobID for non-HA setups
URL: https://github.com/apache/flink/pull/8539#discussion_r290900681
 
 

 ##########
 File path: 
flink-container/src/main/java/org/apache/flink/container/entrypoint/StandaloneJobClusterConfiguration.java
 ##########
 @@ -54,7 +54,7 @@
                        @Nullable String jobClassName) {
                super(configDir, dynamicProperties, args, hostname, restPort);
                this.savepointRestoreSettings = 
requireNonNull(savepointRestoreSettings, "savepointRestoreSettings");
-               this.jobId = requireNonNull(jobId, "jobId");
 
 Review comment:
   The annotation `@Nonnull JobID jobId` in the constructor parameter 
mismatches with new constrain.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to