sunjincheng121 edited a comment on issue #8550: [FLINK-12401][table] Support 
incremental emit under AccRetract mode for non-window streaming FlatAggregate 
on Table API
URL: https://github.com/apache/flink/pull/8550#issuecomment-498913495
 
 
   Since the execution mode of the Stream operator has two modes, `ACC` and 
`ACCRetract`, users can achieve better performance by implementing special 
interfaces for streaming. The table below is a quick summary.
   
     | emitValue | emitUpdateWithRetract | emitUpdateWithoutRetract
   -- | -- | -- | --
   ACC | Y | N | Y
   ACCRetract | Y | Y | N
   
   -emitValue - for batch and streaming.
   -eimitUpdateWithRetract - only for streaming in ACC mode.(need key 
definition on TableAggregateFunction, [under 
discussion](https://docs.google.com/document/d/183qHo8PDG-xserDi_AbGP6YX9aPY0rVr80p3O3Gyz6U/edit#heading=h.evvcpnbn30wn)).
   -emitUpdateWithoutRetract - only for streaming in ACCRetract mode
   
   So, In this PR, change the method name from `emitRetractValueIncrementally` 
to `emitUpdateWithRetract` is better. What do you think?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to