mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics]
Support retention policy for InfluxDB metrics …
URL: https://github.com/apache/flink/pull/8668#discussion_r292227151
##########
File path:
flink-metrics/flink-metrics-influxdb/src/test/java/org/apache/flink/metrics/influxdb/InfluxdbReporterTest.java
##########
@@ -57,6 +57,7 @@
private static final String TEST_INFLUXDB_DB = "test-42";
private static final String METRIC_HOSTNAME = "task-mgr-1";
private static final String METRIC_TM_ID = "tm-id-123";
+ private String retentionPolicy = "";
Review comment:
I did use final variable for retention policy in the test case so that the
createMetricsRegistry can return the registry impl with properties both
default and non-default test scenrios. Please let me now if you have any
additional advice. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
