KurtYoung commented on a change in pull request #8626: [FLINK-12742] Add insert into partition grammar as hive dialect URL: https://github.com/apache/flink/pull/8626#discussion_r292245668
########## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/ddl/SqlMapType.java ########## @@ -25,7 +25,7 @@ import org.apache.calcite.sql.type.SqlTypeName; /** - * Extended Flink MapType. + * Parse column of Map type. Review comment: I think we should move this class out of `ddl` package, as well as other flink defined types. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
