KurtYoung commented on a change in pull request #8678: [FLINK-12708][table] Introduce new source and sink interfaces to make Blink runner work URL: https://github.com/apache/flink/pull/8678#discussion_r292272092
########## File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/AsyncTableFunction.java ########## @@ -0,0 +1,139 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.functions; + +import org.apache.flink.annotation.Experimental; +import org.apache.flink.api.common.functions.InvalidTypesException; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.api.java.typeutils.TypeExtractor; +import org.apache.flink.table.api.ValidationException; + +import java.util.concurrent.CompletableFuture; + +/** + * Base class for a user-defined asynchronously table function (UDTF). This is similar to + * {@link TableFunction} but this function is asynchronously. + * + * <p>A user-defined table functions works on + * zero, one, or multiple scalar values as input and returns multiple rows as output. + * + * <p>The behavior of a {@link AsyncTableFunction} can be defined by implementing a custom evaluation + * method. An evaluation method must be declared publicly, not static and named "eval". + * Evaluation methods can also be overloaded by implementing multiple methods named "eval". + * + * <p>The first parameter of evaluation method must be {@link CompletableFuture}, and the others are + * user defined input parameters like the "eval" method of {@link TableFunction}. The generic type of + * {@link CompletableFuture} must be {@link java.util.Collection} to collect multiple possible result + * values. + * + * <p>For each "eval", an async io operation can be triggered, and once it has been done, + * the result can be collected by calling {@link CompletableFuture#complete}. For each async + * operation, its context is stored in the operator immediately after invoking "eval", + * avoiding blocking for each stream input as long as the internal buffer is not full. + * + * <p>{@link CompletableFuture} can be passed into callbacks or futures to collect the result data. + * An error can also be propagate to the async IO operator by + * {@link CompletableFuture#completeExceptionally(Throwable)}. + * + * <p>User-defined functions must have a default constructor and must be instantiable during + * runtime. + * + * <p>By default the result type of an evaluation method is determined by Flink's type extraction + * facilities. This is sufficient for basic types or simple POJOs but might be wrong for more + * complex, custom, or composite types. In these cases {@link TypeInformation} of the result type + * can be manually defined by overriding {@link #getResultType}. + * + * <p>Internally, the Table/SQL API code generation works with primitive values as much as possible. + * If a user-defined table function should not introduce much overhead during runtime, it is + * recommended to declare parameters and result types as primitive types instead of their boxed + * classes. DATE/TIME is equal to int, TIMESTAMP is equal to long. + * + * <p>Example: + * + * {@code + * + * public class HBaseAsyncTableFunction extends AsyncTableFunction<String> { + * + * // implement an "eval" method with as many parameters as you want + * public void eval(CompletableFuture<Collection<String>> result, String rowkey) { + * Get get = new Get(Bytes.toBytes(rowkey)); + * ListenableFuture<Result> future = hbase.asyncGet(get); + * Futures.addCallback(future, new FutureCallback<Result>() { + * public void onSuccess(Result result) { + * List<String> ret = process(result); + * result.complete(ret); + * } + * public void onFailure(Throwable thrown) { + * result.completeExceptionally(thrown); + * } + * }); + * } + * + * // you can overload the eval method here ... + * } + * } + * + * <p>NOTE: the {@link AsyncTableFunction} can not be used as UDTF currently. It only used in + * temporal table join as an async lookup function. + * + * @param <T> The type of the output row + */ +@Experimental +public abstract class AsyncTableFunction<T> extends UserDefinedFunction { + + /** + * Returns the result type of the evaluation method with a given signature. + * + * <p>This method needs to be overridden in case Flink's type extraction facilities are not + * sufficient to extract the {@link TypeInformation} based on the return type of the evaluation + * method. Flink's type extraction facilities can handle basic types or + * simple POJOs but might be wrong for more complex, custom, or composite types. + * + * @return {@link TypeInformation} of result type or <code>null</code> if Flink should determine the type + */ + public TypeInformation<T> getResultType() { Review comment: I don't think so. `AsyncTableFunction` should first be a table function, it can be treated as normal table function but executed in an aync way. You current solution will make this interface can only apply to lookup join which i think is somehow coupled. We still need to treat these two things separately. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
