StefanRRichter commented on a change in pull request #8692: [FLINK-12804]
Introduce mailbox-based ExecutorService
URL: https://github.com/apache/flink/pull/8692#discussion_r292996232
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -467,7 +496,12 @@ public final void invoke() throws Exception {
@Override
public final void cancel() throws Exception {
- mailbox.clearAndPut(POISON_LETTER);
+ try {
+ List<Runnable> droppedRunnables =
taskMailboxExecutor.getMailbox().clearAndPut(mailboxPoisonLetter);
Review comment:
I had a closer look and the suggestion would change semantics and break some
tests, so I prefer to keep my approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
