bowenli86 commented on a change in pull request #8700: [FLINK-12657][hive] Integrate Flink with Hive UDF URL: https://github.com/apache/flink/pull/8700#discussion_r293207355
########## File path: flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/functions/hive/HiveScalarFunction.java ########## @@ -0,0 +1,107 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.functions.hive; + +import org.apache.flink.annotation.Internal; +import org.apache.flink.api.common.typeinfo.TypeInformation; +import org.apache.flink.table.functions.FunctionContext; +import org.apache.flink.table.functions.ScalarFunction; +import org.apache.flink.table.types.CollectionDataType; +import org.apache.flink.table.types.DataType; +import org.apache.flink.table.types.utils.LegacyTypeInfoDataTypeConverter; + +import org.apache.hadoop.hive.ql.exec.UDF; +import org.apache.hadoop.hive.ql.udf.generic.GenericUDF; +import org.apache.hadoop.hive.serde2.objectinspector.ObjectInspector; + + +/** + * Abstract class to provide more information for Hive {@link UDF} and {@link GenericUDF} functions. + */ +@Internal +public abstract class HiveScalarFunction<UDFType> extends ScalarFunction implements HiveFunction { + + protected final HiveFunctionWrapper<UDFType> hiveFunctionWrapper; + + protected Object[] constantArguments; + protected DataType[] argTypes; + + protected transient UDFType function; + protected transient ObjectInspector returnInspector; + + private transient boolean isArgsSingleArray; + + HiveScalarFunction(HiveFunctionWrapper<UDFType> hiveFunctionWrapper) { + this.hiveFunctionWrapper = hiveFunctionWrapper; + } + + @Override + public void setArgumentTypesAndConstants(Object[] constantArguments, DataType[] argTypes) { + this.constantArguments = constantArguments; + this.argTypes = argTypes; + } + + @Override + public boolean isDeterministic() { + try { + org.apache.hadoop.hive.ql.udf.UDFType udfType = + hiveFunctionWrapper.getUDFClass() + .getAnnotation(org.apache.hadoop.hive.ql.udf.UDFType.class); + + return udfType != null && udfType.deterministic() && !udfType.stateful(); + } catch (ClassNotFoundException e) { + throw new FlinkHiveUDFException(e); + } + } + + @Override + public TypeInformation getResultType(Class[] signature) { + return LegacyTypeInfoDataTypeConverter.toLegacyTypeInfo( + getHiveResultType(this.constantArguments, this.argTypes)); + } + + @Override + public void open(FunctionContext context) { + openInternal(); + isArgsSingleArray = argTypes.length == 1 && (argTypes[0] instanceof CollectionDataType); Review comment: Good catch on the multiset thing! What do you mean by the primitive array case? BTW, the point here is that `HiveFunction` and its APIs are *temporary*. We don't know how and in which form the types are gonna be passed in yet, and this part should be refactored later to adapt to any outcome of the type system rework. So I think it's ok to not over-emphasize on this part for now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
