wuchong commented on a change in pull request #8736: [FLINK-12846][table] Carry
primary key and unique key information in TableSchema
URL: https://github.com/apache/flink/pull/8736#discussion_r294126584
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/util/TableTestBase.scala
##########
@@ -147,13 +161,15 @@ abstract class TableTestUtil(test: TableTestBase) {
* @param types field types
* @param fields field names
* @param statistic statistic of current table
+ * @param uniqueKeys unique keys of current table
* @return returns the registered [[Table]].
*/
def addTableSource(
name: String,
types: Array[TypeInformation[_]],
fields: Array[String],
- statistic: FlinkStatistic = FlinkStatistic.UNKNOWN): Table
+ statistic: TableStats,
Review comment:
If the more information we need add to `FlinkStatistic`, I think it should
also be included in `TableStats`. Regarding to the `relModifiedMonotonicity`,
it is only be used internally in intermediate table source
(`IntermediateRelTable`) which keeps `FlinkStatistic` as the constructor
parameter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
