bowenli86 commented on a change in pull request #8784:
[FLINK-12892][table][hive] serialize catalog table to properties for table
discovery service
URL: https://github.com/apache/flink/pull/8784#discussion_r295010635
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/HiveCatalogTable.java
##########
@@ -65,11 +65,4 @@ public CatalogBaseTable copy() {
return Optional.ofNullable(getComment());
}
- @Override
- public Map<String, String> toProperties() {
- // TODO: output properties that are used to auto-discover
TableFactory for Hive tables.
Review comment:
right, I'm actually working on combining the two tables now. Maybe we can
just keep this PR as-is? there's not much difference to make it happen sooner
than later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
