pnowojski commented on a change in pull request #8731: [FLINK-11878][runtime]
Implement the runtime handling of BoundedOneInput and BoundedMultiInput
URL: https://github.com/apache/flink/pull/8731#discussion_r295237361
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
##########
@@ -95,6 +98,11 @@
*/
private StreamStatus streamStatus = StreamStatus.ACTIVE;
+ /** The bit flag that tracks finished inputs. */
+ private int finishedInputs = 0;
Review comment:
You are duplicating logic from `InputSelection` for all of those binary
operations. I would just use `InputSelection` for finished inputs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
