bowenli86 commented on a change in pull request #8785: [FLINK-11480][hive]
Create HiveTableFactory that creates TableSource/…
URL: https://github.com/apache/flink/pull/8785#discussion_r295962778
##########
File path:
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/factories/TableFactoryUtil.java
##########
@@ -83,4 +86,19 @@ public static ExternalCatalog
findAndCreateExternalCatalog(Descriptor descriptor
return tableSink;
}
+
+ /**
+ * Returns a table sink matching the descriptor.
+ */
+ public static <T> TableSink<T> findAndCreateTableSink(CatalogTable
table) {
Review comment:
I actually wonder if we can just call
`findAndCreateTableSink(table.toProperties()) ` in `HiveTableFactory` rather
than adding the two new utils? `TableFactoryUtil` just need a set of
properties, and doesn't seem to need to understand how a CatalogTable serialize
itself into a set of properties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
