WeiZhong94 commented on a change in pull request #8681: [FLINK-12585][python] 
Align Stream/BatchTableEnvironment with JAVA Table API
URL: https://github.com/apache/flink/pull/8681#discussion_r296074136
 
 

 ##########
 File path: flink-python/pyflink/table/table_config.py
 ##########
 @@ -119,7 +116,7 @@ def get_built_in_database_name(self):
         """
         return self._j_table_config.getBuiltInDatabaseName()
 
-    def _set_built_in_database_name(self, built_in_database_name):
+    def set_built_in_database_name(self, built_in_database_name):
 
 Review comment:
   This is Because `TableConfig` class has been refactored to old design in 
this PR. So I refactored these newly added setter method in this PR too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to