godfreyhe commented on a change in pull request #8782: [FLINK-12888] [table-planner-blink] Introduce planner rule to push filter into TableSource URL: https://github.com/apache/flink/pull/8782#discussion_r296084274
########## File path: flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/expressions/RexNodeConverter.java ########## @@ -168,6 +170,12 @@ private RexNode visitScalarFunc(UnresolvedCallExpression unresolvedCall) { return relBuilder.call(FlinkSqlOperatorTable.MULTIPLY, child); } else if (BuiltInFunctionDefinitions.MOD.equals(def)) { return relBuilder.call(FlinkSqlOperatorTable.MOD, child); + } else if (def instanceof ScalarFunctionDefinition) { + // TODO add getName for ScalarFunctionDefinition ??? Review comment: thanks for the correction. `List<RexNode> child = convertCallChildren(call);` is defined at line 122 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services