JingsongLi commented on a change in pull request #8782: [FLINK-12888]
[table-planner-blink] Introduce planner rule to push filter into TableSource
URL: https://github.com/apache/flink/pull/8782#discussion_r296096283
##########
File path:
flink-table/flink-table-planner-blink/src/main/java/org/apache/flink/table/expressions/RexNodeConverter.java
##########
@@ -168,6 +170,12 @@ private RexNode visitScalarFunc(UnresolvedCallExpression
unresolvedCall) {
return relBuilder.call(FlinkSqlOperatorTable.MULTIPLY,
child);
} else if (BuiltInFunctionDefinitions.MOD.equals(def)) {
return relBuilder.call(FlinkSqlOperatorTable.MOD,
child);
+ } else if (def instanceof ScalarFunctionDefinition) {
+ // TODO add getName for ScalarFunctionDefinition ???
Review comment:
Now we just use `functionIdentifier` to be name.
The detail reason is in https://github.com/apache/flink/pull/3330
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
