dianfu opened a new pull request #8840: [FLINK-12931][python] Fix 
lint-python.sh cannot find flake8
URL: https://github.com/apache/flink/pull/8840
 
 
   ## What is the purpose of the change
   
   *The lint-python.sh will execute failed during installing flake8 when there 
is anaconda2/anaconda3 installed. We need to solve this issue because anaconda 
is a pretty common package that developers install and use. 
   The reason to this issue is that `conda install flake8` will try to install 
flake8 into the conda home which may be the conda installed by user, not the 
miniconda installed by lint-python.sh.*
   
   
   ## Brief change log
   
     - *Updates lint-python.sh to specify the conda home explicitly when 
executing `conda remove` and `conda install`*
   
   ## Verifying this change
   
   This change can be verified as follows:
   
     - *Executes ./dev/lint-python.sh and it will succeed*
     - *Installs anaconda2/anaconda3, starts a new shell and makes sure the 
newly installed anaconda2/anaconda3 is used.*
     - *Executes ./dev/lint-python.sh -f and it will fail without the changes 
of this PR*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to