1u0 commented on a change in pull request #8692: [FLINK-12804] Introduce mailbox-based ExecutorService URL: https://github.com/apache/flink/pull/8692#discussion_r296599606
########## File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java ########## @@ -252,23 +261,31 @@ protected StreamTask( * Runs the stream-tasks main processing loop. */ private void run() throws Exception { - final ActionContext actionContext = new ActionContext(); + final Mailbox mailbox = taskMailboxExecutor.getMailbox(); Review comment: Same as for `SourceStreamTask.runAlternativeMailboxLoop()`, you can add a precondition check that this method is called in the proper thread. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services