[ 
https://issues.apache.org/jira/browse/FLINK-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871926#comment-16871926
 ] 

xymaqingxiang edited comment on FLINK-12909 at 6/25/19 2:13 AM:
----------------------------------------------------------------

First of all, thank you for the review [~NicoK].

I had an discussion with [~zjwang] about this pr 
[7197](https://github.com/apache/flink/pull/7197), It makes sense to ignore the 
exception during retry logic to enhance stable.

Disk loss is just one of the problems, The goal is to make 10 attempts work.


was (Author: xymaqingxiang):
First of all, thank you for the review [~NicoK].

I had an discussion with [~zjwang] about this pr [#7197], It makes sense to 
ignore the exception during retry logic to enhance stable.

Disk loss is just one of the problems, The goal is to make 10 attempts work.

> add try catch when find a unique file name for the spilling channel
> -------------------------------------------------------------------
>
>                 Key: FLINK-12909
>                 URL: https://issues.apache.org/jira/browse/FLINK-12909
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Network
>            Reporter: xymaqingxiang
>            Priority: Major
>
> h2. What is the purpose of the change
> Catch exceptions thrown due to disk loss, try to find a unique file name for 
> the spilling channel again.
> Modify the createSpillingChannel() method of the 
> org.apache.flink.runtime.io.network.api.serialization.SpillingAdaptiveSpanningRecordDeserializer
>  class to solve this problem.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to