[ 
https://issues.apache.org/jira/browse/FLINK-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16871941#comment-16871941
 ] 

zhijiang commented on FLINK-12909:
----------------------------------

The ticket does not describes the issue well.

Any IOException thrown by `createNewFile` would make the attempt loop end to 
jump out, so the initial motivation was ignoring the intermediate exceptions to 
confirm all the attempts finish, otherwise the attempt logic seems useless. 
Also the new added warn log could show the specific failure reason for helping 
trace.

It might be an option to wait some time for each attempt as Nico mentioned to 
enhance it, because in most cases the exceptions might still exist during these 
attempts, or we could remove the attempt loop directly to make it clear.

 

> add try catch when find a unique file name for the spilling channel
> -------------------------------------------------------------------
>
>                 Key: FLINK-12909
>                 URL: https://issues.apache.org/jira/browse/FLINK-12909
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Network
>            Reporter: xymaqingxiang
>            Priority: Major
>
> h2. What is the purpose of the change
> Catch exceptions thrown due to disk loss, try to find a unique file name for 
> the spilling channel again.
> Modify the createSpillingChannel() method of the 
> org.apache.flink.runtime.io.network.api.serialization.SpillingAdaptiveSpanningRecordDeserializer
>  class to solve this problem.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to