GJL commented on a change in pull request #8851: [FLINK-12876] [runtime] Add an 
adapter of region failover NG for legacy scheduler
URL: https://github.com/apache/flink/pull/8851#discussion_r297075773
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/FailoverStrategyLoader.java
 ##########
 @@ -63,7 +63,7 @@
                                        return new RestartAllStrategy.Factory();
 
                                case PIPELINED_REGION_RESTART_STRATEGY_NAME:
 
 Review comment:
   Here is what I think:
   - default will use `AdaptedRestartPipelinedRegionStrategyNG`
   - `region-legacy` will use `RestartPipelinedRegionStrategy`
   - `region` will use `AdaptedRestartPipelinedRegionStrategyNG`
   
   User will get the best experience out of the box but can switch to old 
behavior in case of bugs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to