zentol commented on a change in pull request #8778: [FLINK-12615][coordination] 
Track partitions on JM
URL: https://github.com/apache/flink/pull/8778#discussion_r297093692
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java
 ##########
 @@ -876,6 +887,17 @@ private void jobStatusChanged(
                validateRunsInMainThread();
 
                if (newJobStatus.isGloballyTerminalState()) {
+                       // other terminal job states are handled by the 
executions
+                       if (newJobStatus == JobStatus.FINISHED) {
+                               scheduledExecutorService.execute(() -> {
+                                       for (Map.Entry<ResourceID, 
Tuple2<TaskManagerLocation, TaskExecutorGateway>> entry : 
registeredTaskManagers.entrySet()) {
 
 Review comment:
   yes, we should run this in the JM main thread instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to