xintongsong commented on a change in pull request #8841:
[FLINK-12765][coordinator] Bookkeeping of available resources of allocated
slots in SlotPool
URL: https://github.com/apache/flink/pull/8841#discussion_r297470517
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/SlotSharingManager.java
##########
@@ -177,14 +181,18 @@ MultiTaskSlot createRootSlot(
}
@Nonnull
- public Collection<SlotInfo> listResolvedRootSlotInfo(@Nullable
AbstractID groupId) {
+ public Collection<SlotSelectionStrategy.SlotInfoAndRemainingResource>
listResolvedRootSlotInfo(@Nullable AbstractID groupId) {
return resolvedRootSlots
.values()
.stream()
- .flatMap((Map<AllocationID, MultiTaskSlot> map) ->
map.values().stream())
- .filter((MultiTaskSlot multiTaskSlot) ->
!multiTaskSlot.contains(groupId))
- .map((MultiTaskSlot multiTaskSlot) -> (SlotInfo)
multiTaskSlot.getSlotContextFuture().join())
- .collect(Collectors.toList());
+ .flatMap((Map<AllocationID, MultiTaskSlot> map)
-> map.values().stream())
+ .filter((MultiTaskSlot multiTaskSlot) ->
!multiTaskSlot.contains(groupId))
Review comment:
indent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
