zhijiangW commented on a change in pull request #8455:
[FLINK-12284,FLINK-12637][Network,Metrics]Fix the incorrect inputBufferUsage
metric in credit-based network mode
URL: https://github.com/apache/flink/pull/8455#discussion_r297493392
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/metrics/NettyShuffleMetricFactory.java
##########
@@ -66,6 +66,8 @@
private static final String METRIC_INPUT_QUEUE_LENGTH =
"inputQueueLength";
private static final String METRIC_INPUT_POOL_USAGE = "inPoolUsage";
+ private static final String METRIC_INPUT_FLOATING_BUFFERS_USAGE =
"floatingBuffersUsage";
Review comment:
floatingBuffersUsage -> inputFloatingBuffersUsage, also add the `input`
prefix for following `exclusiveBuffersUsage`, then it is easy to distinguish
from the metric name and keep consistent with other.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
