1u0 commented on a change in pull request #8741: [FLINK-12752] Add Option to
Pass Seed for JobID Hash for StandaloneJobClusterEntrypoint
URL: https://github.com/apache/flink/pull/8741#discussion_r297561629
##########
File path:
flink-container/src/test/java/org/apache/flink/container/entrypoint/StandaloneJobClusterEntryPointTest.java
##########
@@ -67,54 +65,109 @@ public void testDontOverwriteExecutionMode() {
}
@Test
- public void configuredJobIDTakesPrecedenceWithHA() {
- Optional<JobID> jobID = Optional.of(JobID.generate());
+ public void configuredJobIdTakesPrecedenceWithHA() {
Review comment:
Not required here, but imo, those tests that check precedence order would be
better if they are rewritten as one test that checks all cases as table input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
