mans2singh commented on a change in pull request #8668: [FLINK-12784][metrics]
Support retention policy for InfluxDB metrics …
URL: https://github.com/apache/flink/pull/8668#discussion_r297897324
##########
File path:
flink-metrics/flink-metrics-influxdb/src/test/java/org/apache/flink/metrics/influxdb/InfluxdbReporterTest.java
##########
@@ -111,18 +112,20 @@ public void testMetricReporting() throws Exception {
verify(postRequestedFor(urlPathEqualTo("/write"))
.withQueryParam("db", equalTo(TEST_INFLUXDB_DB))
+ .withQueryParam("rp", equalTo(retentionPolicy))
.withHeader("Content-Type",
containing("text/plain"))
.withRequestBody(containing("taskmanager_" +
metricName + ",host=" + METRIC_HOSTNAME + ",tm_id=" + METRIC_TM_ID + "
count=42i")));
} finally {
metricRegistry.shutdown().get();
}
}
- private MetricRegistryImpl createMetricRegistry() {
+ private MetricRegistryImpl createMetricRegistry(String retentionPolicy)
{
MetricConfig metricConfig = new MetricConfig();
metricConfig.setProperty("host", "localhost");
metricConfig.setProperty("port",
String.valueOf(wireMockRule.port()));
metricConfig.setProperty("db", TEST_INFLUXDB_DB);
+ metricConfig.setProperty("retentionPolicy", retentionPolicy);
Review comment:
Corrected based on recommendations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
