godfreyhe commented on a change in pull request #8898:
[FLINK-12936][table-planner-blink] Support intersect/minus all to blink planner
URL: https://github.com/apache/flink/pull/8898#discussion_r297962742
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/rules/logical/ReplaceSetOpWithJoinRuleBase.scala
##########
@@ -55,4 +71,47 @@ abstract class ReplaceSetOpWithJoinRuleBase[T <: SetOp](
}
conditions
}
+
+ protected def replicateRows(
Review comment:
the class name `ReplaceSetOpWithJoinRuleBase` is not proper now, because
`RewriteIntersectAll` and `RewriteMinusAll` will not rewrite `IntersectAll` and
`MinusAll` to a join
please add javadoc for this method
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
