wsry commented on a change in pull request #8880: [FLINK-12986] [network] Fix
instability of BoundedBlockingSubpartition under memory pressure.
URL: https://github.com/apache/flink/pull/8880#discussion_r298050105
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/BoundedBlockingSubpartitionReader.java
##########
@@ -44,7 +44,7 @@
/** The reader/decoder to the memory mapped region with the data we
currently read from.
* Null once the reader empty or disposed.*/
@Nullable
- private BufferSlicer memory;
+ private BoundedData.Reader data;
Review comment:
Maybe “dataReader” is better than “data” to distinguish from instance of
BoundedData.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
