zhijiangW commented on a change in pull request #8880: [FLINK-12986] [network]
Fix instability of BoundedBlockingSubpartition under memory pressure.
URL: https://github.com/apache/flink/pull/8880#discussion_r298093109
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/MemoryMappedBoundedData.java
##########
@@ -220,28 +225,29 @@ private static int alignSize(int maxRegionSize) {
* The "reader" for the memory region. It slices a sequence of buffers
from the
* sequence of mapped ByteBuffers.
*/
- static final class BufferSlicer {
+ static final class BufferSlicer implements BoundedData.Reader {
- /** The reader/decoder to the memory mapped region with the
data we currently read from.
+ /** The memory mapped region we currently read from.
* Max 2GB large. Further regions may be in the {@link
#furtherData} field. */
- private BufferToByteBuffer.Reader data;
+ private ByteBuffer data;
Review comment:
it might be better to name `currentData` comparing with `furtherData`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
