1u0 commented on a change in pull request #8692: [FLINK-12804] Introduce
mailbox-based ExecutorService
URL: https://github.com/apache/flink/pull/8692#discussion_r298176939
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -226,13 +219,18 @@ protected StreamTask(
this.accumulatorMap =
getEnvironment().getAccumulatorRegistry().getUserMap();
this.recordWriters = createRecordWriters(configuration,
environment);
this.syncSavepointLatch = new SynchronousSavepointLatch();
- this.mailbox = new MailboxImpl();
+ this.mailboxProcessor = new MailboxProcessor(this);
Review comment:
I think you wouldn't need to touch subclasses with the change I've proposed.
My main motivation is to not have `MailboxDefaultAction` implementation
exposed as `public` api of `StreamTask`, as it's more internal implementation
detail.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
