liyafan82 commented on issue #8773: [FLINK-12879][Table SQL / Runtime] Improve the performance of AbstractBinaryWriter URL: https://github.com/apache/flink/pull/8773#issuecomment-506638490 > Thanks @liyafan82 , the reason why copy data to tmp byte[] is that `SegmentsUtil.getByte` has poor performance. The simple getByte shouldn't be so many codes. > So my judgement is: copy bytes should quicker. @JingsongLi Thanks for the clarification. I should have thought more about it before submitting this PR.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
